Carlos Garnacho [Thu, 12 Nov 2020 23:23:52 +0000 (00:23 +0100)]
gtk/main: Stack ::active calls
We may have the situation of multiple touchpoints in the same
widget, or combinations with other devices. Stack those ::active
states are preserved on widgets on all but the last pointer/touch
going away.
Carlos Garnacho [Thu, 12 Nov 2020 16:31:52 +0000 (17:31 +0100)]
gtk/main: Toggle active flag with touch events
This went missing at some point, add the missing toggling of active
state with GDK_TOUCH_BEGIN/END/CANCEL events.
Fixes: https://gitlab.gnome.org/GNOME/gtk/-/issues/3348
Emmanuele Bassi [Thu, 12 Nov 2020 22:22:20 +0000 (22:22 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
See merge request GNOME/gtk!2819
Emmanuele Bassi [Thu, 12 Nov 2020 21:12:56 +0000 (21:12 +0000)]
a11y: Use GROUP role for ShortcutsShortcut
And hide the image from the accessible tree.
Emmanuele Bassi [Thu, 12 Nov 2020 20:57:56 +0000 (20:57 +0000)]
a11y: Implement atspi.Text.ScrollSubstringTo for GtkTextView
We reuse the existing implementation in GTK3.
Emmanuele Bassi [Thu, 12 Nov 2020 16:19:14 +0000 (16:19 +0000)]
a11y: Document GtkRevealer's accessible state
Use the GROUP role, and make sure to note that the child is always
revealed. Unlike GtkExpander, GtkRevealer can only be programmatically
toggled, so we cannot turn it into a "button" object.
Emmanuele Bassi [Thu, 12 Nov 2020 16:16:48 +0000 (16:16 +0000)]
a11y: Add more accessible data to GtkTreeExpander
Document the role of the GtkTreeExpander, and the behaviour of the
expander button.
Additionally, improve the label of the expander button, by adding a
fixed "Expand" label, and setting the "labelled-by" relation to the
child of the GtkTreeExpander.
Emmanuele Bassi [Thu, 12 Nov 2020 16:12:03 +0000 (16:12 +0000)]
Establish a control relation between demo search and list
The search entry changes the content of the list view, so we should
mention that relation to assistive technologies.
Emmanuele Bassi [Thu, 12 Nov 2020 16:05:31 +0000 (16:05 +0000)]
a11y: Add accessible actions to GtkSearchEntry
Just like GtkPasswordEntry, GtkSearchEntry should have its set of
accessible actions.
Emmanuele Bassi [Thu, 12 Nov 2020 16:04:30 +0000 (16:04 +0000)]
a11y: Mark SearchEntry icons as presentational
While the "clear the search entry" icon behaves like a button, we don't
have any actual action that can trigger it, so let's ignore it.
Emmanuele Bassi [Thu, 12 Nov 2020 14:54:39 +0000 (14:54 +0000)]
a11y: Set the role on GtkSearchBar
The search bar widget has a "SEARCH" landmark role, which is described
as:
A landmark region that contains a collection of items and
objects that, as a whole, combine to create a search facility.
Emmanuele Bassi [Thu, 12 Nov 2020 14:53:16 +0000 (14:53 +0000)]
a11y: Icons in buttons are presentational
Buttons are described by text, and the icon child can be safely ignored.
Emmanuele Bassi [Thu, 12 Nov 2020 14:51:58 +0000 (14:51 +0000)]
a11y: Add more accessibility labels to GtkNotebook
Label the various components:
- the tab list
- the tab widget
- the arrow widgets
Emmanuele Bassi [Thu, 12 Nov 2020 14:50:49 +0000 (14:50 +0000)]
a11y: Use the stack page title as its accessible label
Emmanuele Bassi [Thu, 12 Nov 2020 14:50:35 +0000 (14:50 +0000)]
a11y: GtkStack is a group of stack pages
Emmanuele Bassi [Thu, 12 Nov 2020 16:48:03 +0000 (16:48 +0000)]
Handle empty stack pages when creating an ATContext
If we don't have a widget inside GtkStackPage, we should use the default
GdkDisplay.
Emmanuele Bassi [Thu, 12 Nov 2020 14:49:16 +0000 (14:49 +0000)]
Unrealize the ATContext in StackPage on dispose
Otherwise we're going to try to unrealize it during the GtkStack
destruction, which will emit warnings.
Emmanuele Bassi [Thu, 12 Nov 2020 14:48:15 +0000 (14:48 +0000)]
a11y: Icons in WindowControls are presentational only
They don't contribute anything to the accessible description.
Emmanuele Bassi [Thu, 12 Nov 2020 14:38:01 +0000 (14:38 +0000)]
a11y: Ignore more structural roles when computing labels
These roles should not have a fallback name when explicitly unlabelled.
Emmanuele Bassi [Thu, 12 Nov 2020 14:37:21 +0000 (14:37 +0000)]
a11y: Add role exception for GtkScrolledWindow
ARIA does not have a "scroll pane" role, but AT-SPI does.
Emmanuele Bassi [Thu, 12 Nov 2020 14:36:59 +0000 (14:36 +0000)]
demo: Add more accessibility labels to the UI
Matthias Clasen [Thu, 12 Nov 2020 19:25:57 +0000 (19:25 +0000)]
Merge branch 'clear-search-entry' into 'master'
searchbar: Fix clearing search entry on hide
See merge request GNOME/gtk!2820
Florian Müllner [Thu, 12 Nov 2020 18:04:42 +0000 (19:04 +0100)]
searchbar: Fix clearing search entry on hide
Commit
fa3d1940bf2b36 added separate grab handling for GtkSearchEntry, but
didn't consider whether the bar was revealed or concealed. The expected
behavior for the latter is that the entry is cleared rather than focused,
fix the condition accordingly.
Matthias Clasen [Thu, 12 Nov 2020 12:35:23 +0000 (12:35 +0000)]
Merge branch 'ebassi/for-master' into 'master'
ATContext lifetime fixes
Closes #3341
See merge request GNOME/gtk!2811
Jakub Steiner [Thu, 12 Nov 2020 12:34:10 +0000 (12:34 +0000)]
Merge branch 'wip/jimmac/sassc-global-vars' into 'master'
Adwaita: avoid !global
See merge request GNOME/gtk!2816
Jakub Steiner [Thu, 12 Nov 2020 12:14:37 +0000 (13:14 +0100)]
Adwaita: avoid !global
- Work around having !global variables as sassc will
no longer support it
Emmanuele Bassi [Thu, 12 Nov 2020 00:36:32 +0000 (00:36 +0000)]
docs: Add "Accessibility" section to various widgets
There are a few widgets that gained an accessible role, which means
adding an "Accessibility" section in their description.
Matthias Clasen [Wed, 11 Nov 2020 21:40:07 +0000 (21:40 +0000)]
Merge branch 'suggestion-entry-demo2' into 'master'
gtk-demo: Add suggestion entry demos
See merge request GNOME/gtk!2812
Matthias Clasen [Thu, 25 Jun 2020 17:57:17 +0000 (13:57 -0400)]
gtk-demo: Add suggestion entry demos
Add a possible replacement for GtkEntryCompletion
as a demo.
Move the Dropdowns demo to Lists/Selections, and make
it show both GtkDropDown and the suggestion entry, with
some variations.
Matthias Clasen [Wed, 11 Nov 2020 20:49:51 +0000 (20:49 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2810
Emmanuele Bassi [Wed, 11 Nov 2020 18:31:32 +0000 (18:31 +0000)]
a11y: Simplify GtkModelButton
Instead of recreating GtkATContexts in order to change their role, we
can simply unrealize and realize them back.
Emmanuele Bassi [Wed, 11 Nov 2020 19:36:38 +0000 (19:36 +0000)]
a11y: Add missing fallback for accessible-role getter
If the per-instance accessible role is unset, use the class role.
Emmanuele Bassi [Wed, 11 Nov 2020 18:17:41 +0000 (18:17 +0000)]
a11y: Rework ownership and lifetime of GtkATContext
Now that GtkATContext is explicitly realized and unrealized, we should
always create an instance at widget initialization time, and drop it
during the widget finalization. This should make it easier to set up the
initial accessible state of a widget during the instance initialization,
as well as reduce the chances of accidental creation of GtkATContext
instances during the destruction sequence.
Emmanuele Bassi [Wed, 11 Nov 2020 19:37:26 +0000 (19:37 +0000)]
a11y: Defer to the GtkAccessible's implementation
Since GtkATContexts are now lazily realized, we need to go through the
GtkAccessible's implementation to access the :accessible-role property,
in case there are fallbacks.
Emmanuele Bassi [Wed, 11 Nov 2020 18:15:18 +0000 (18:15 +0000)]
a11y: Create AtSpiRoot on realization
There's no need to do a lot of work on construction, if we're delaying
all remote work after the GtkATContext is realized.
The GtkAtSpiContext should also keep a reference on the root, and drop
it at unrealize time.
Emmanuele Bassi [Wed, 11 Nov 2020 18:11:10 +0000 (18:11 +0000)]
a11y: Use GROUP role for GtkNotebook
A notebook is a grouping of a tab list, tabs, and tab pages.
Emmanuele Bassi [Wed, 11 Nov 2020 18:09:43 +0000 (18:09 +0000)]
a11y: Protect should_present() from empty contexts
If the GtkAccessible implementation returns a NULL context, we should
not be calling methods on it.
Emmanuele Bassi [Wed, 11 Nov 2020 18:08:16 +0000 (18:08 +0000)]
a11y: Do not leak the ATContext in GtkStackPage
GtkStackPage is not a widget, so it must release the reference on the
ATContext it owns.
Emmanuele Bassi [Wed, 11 Nov 2020 17:54:57 +0000 (17:54 +0000)]
a11y: Mark more containers as structural elements
Widgets that just provide grouping and layout to other widgets should
not be relevant to the accessible tree.
Emmanuele Bassi [Wed, 11 Nov 2020 17:51:56 +0000 (17:51 +0000)]
a11y: Use the window title as its label
Emmanuele Bassi [Wed, 11 Nov 2020 17:50:42 +0000 (17:50 +0000)]
a11y: Skip unlabelled structural roles
If a structural role is left unlabelled, just leave it unnamed.
Emmanuele Bassi [Wed, 11 Nov 2020 17:49:38 +0000 (17:49 +0000)]
a11y: Translate ARIA windows to AT-SPI frames
For backward compatibility with GTK3.
Emmanuele Bassi [Wed, 11 Nov 2020 17:49:14 +0000 (17:49 +0000)]
a11y: Add more ARIA/AT-SPI role translations
Emmanuele Bassi [Wed, 11 Nov 2020 17:45:32 +0000 (17:45 +0000)]
a11y: Realize parent ATContext for the stack page
Just like for popovers, the stack page is not directly connected on the
widget's DOM, so we need to realize the parent ATContext ourselves.
Emmanuele Bassi [Wed, 11 Nov 2020 17:43:44 +0000 (17:43 +0000)]
a11y: Implement missing atspi.Component getters
Some of them are entirely innocuous, and we can easily provide values
that match what GTK3 provides.
Emmanuele Bassi [Tue, 10 Nov 2020 17:18:55 +0000 (17:18 +0000)]
a11y: Unrealize ATContext on dispose()
By unrealizing the context we avoid additional work during the dispose
phase, in case widget code updates the accessible state. We use
GtkAccessible's API, to ensure we unrealize the right ATContext, instead
of the one we store inside GtkWidgetPrivate.
We drop the ATContext instance inside GtkWidget during finalization, to
mop up eventual vivifications there.
Matthias Clasen [Wed, 11 Nov 2020 18:07:31 +0000 (13:07 -0500)]
Adwaita: Don't do n-th child things for list rows
Making the list row child css depend on the position
is very expensive, and does not acutally work correctly
(since we don't have widgets for all children, so the
position of the child widget does not reflect the actual
model item position).
To make this more palatable, use the bottom border
instead of the top border, since most lists have a natural
border at the top (with headers), and may end up with
empty space at the bottom.
Matthias Clasen [Wed, 11 Nov 2020 17:24:35 +0000 (12:24 -0500)]
label: Avoid a needless strdup
Don't duplicate the string before we know if it
has actually changed.
Matthias Clasen [Wed, 11 Nov 2020 15:35:09 +0000 (10:35 -0500)]
label: Optimize GtkLabel setters
The overarching goal here is to not queue a resize
unless something has actually changed. In columnview
scenarios, we often deal with hundreds of labels.
Labels are cattle, not pets.
Matthias Clasen [Tue, 10 Nov 2020 21:12:16 +0000 (16:12 -0500)]
gtk-demo: Split off SvgPaintable
Put the SvgPaintable implementation into its
own source files, for ease of copying.
Matthias Clasen [Tue, 10 Nov 2020 20:07:07 +0000 (15:07 -0500)]
Don't hide widgets in dispose()
This is leftover code from when widgets were hidden
by default, and was setting them back to their initial
state.
This is getting in the way now, as hiding the widget
updates the HIDDEN accessible state, which ends up
re-creating the at context that we've already disposed
of, leading to memory leaks.
Matthias Clasen [Wed, 11 Nov 2020 03:53:52 +0000 (03:53 +0000)]
Merge branch 'matthiasc/builder-requires' into 'master'
Matthiasc/builder requires
See merge request GNOME/gtk!2806
Matthias Clasen [Wed, 11 Nov 2020 03:50:46 +0000 (03:50 +0000)]
Merge branch 'fix-demos-wo-pangoft2' into 'master'
gtk-demo: Fix building scrolling demo without PangoFT2
See merge request GNOME/gtk!2807
Chun-wei Fan [Wed, 11 Nov 2020 03:08:38 +0000 (11:08 +0800)]
gtk-demo: Fix building scrolling demo without PangoFT2
For builds that do not have PangoFT2, the demo fails to link because we weren't
building listview_ucd.c. Fix the build by building listview_ucd.c with
script-names.c and unicode-names.c for all builds, as we now require a Pango
version that already always depends on HarfBuzz and those sources do not use
anything from PangoFT2.
Matthias Clasen [Wed, 11 Nov 2020 00:20:51 +0000 (19:20 -0500)]
testsuite: Update buildertool tests
gtk-builder-tool simplify --3to4 now produces a
<requires lib="gtk" version="4.0"/>.
Adapt for that, and also add some tests that check that we
actually verify the requires, and accept 3.99 and 4.0, but
not 5.x.
Matthias Clasen [Wed, 11 Nov 2020 00:19:40 +0000 (19:19 -0500)]
buildertool: Supplant a requires
When we convert a ui file to GTK 4 syntax, we *know*
that it requires GTK 4, so put that in the output.
Matthias Clasen [Wed, 11 Nov 2020 00:18:26 +0000 (19:18 -0500)]
builder: Be a bit more strict about requires
Check that the major version matches (without this, the
requires check is really toothless), but allow 3.99 to
match 4.0.
Matthias Clasen [Wed, 11 Nov 2020 00:17:45 +0000 (19:17 -0500)]
testsuite: Remove <requires> from ui files
We don't need these here, the testsuite is shipped
with GTK.
Matthias Clasen [Tue, 10 Nov 2020 23:38:54 +0000 (18:38 -0500)]
examples: Remove requires from ui files
No need to check requires for things that are shipped
with GTK.
Matthias Clasen [Tue, 10 Nov 2020 23:37:40 +0000 (18:37 -0500)]
gtk4-demo: Remove <requires> from ui files
No need to check requires for things that are shipped
with GTK.
Matthias Clasen [Tue, 10 Nov 2020 23:36:03 +0000 (18:36 -0500)]
gtk: Remove <requires> from ui files
We don't need to check requirements for things
that are shipped *with* gtk.
Matthias Clasen [Tue, 10 Nov 2020 18:33:36 +0000 (18:33 +0000)]
Merge branch 'ebassi/for-master' into 'master'
Ebassi/for master
Closes #3343 and #3342
See merge request GNOME/gtk!2804
Matthias Clasen [Tue, 10 Nov 2020 16:59:47 +0000 (16:59 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2805
Emmanuele Bassi [Tue, 10 Nov 2020 14:38:09 +0000 (14:38 +0000)]
docs: Add example of relations with lists of references
Emmanuele Bassi [Tue, 10 Nov 2020 14:21:32 +0000 (14:21 +0000)]
a11y: Clone GtkATContext in GtkModelButton
The hypothetical widget that needs to clone ATContext instances
because it needs to control the accessible role post-construction is
really GtkModelButton.
Fixes: #3342
Emmanuele Bassi [Tue, 10 Nov 2020 14:19:32 +0000 (14:19 +0000)]
a11y: Add private API to clone a GtkATContext
Some widgets might want to override GtkAccessible and create their own
context in order to control the accessible role post-construction time.
To avoid explicitly copying the existing state over from the original
ATContext to the new one, we need a way to clone the context's state
from inside the ATContext itself.
Emmanuele Bassi [Tue, 10 Nov 2020 14:17:11 +0000 (14:17 +0000)]
a11y: Do not copy the list of references
The constructor for GtkReferenceListAccessibleValue is transfer full,
which means we should not be copying the GList around.
Fixes: #3343
Emmanuele Bassi [Tue, 10 Nov 2020 14:14:47 +0000 (14:14 +0000)]
a11y: Parse reference lists using varargs
Using GList is a bit lame, and makes the API more complicated to use
than necessary in the common case.
The only real use case for a GList is gtk_widget_add_mnemonic_label(),
and for that we can use the GValue-based API instead.
Fixes: #3343
Emmanuele Bassi [Tue, 10 Nov 2020 14:08:16 +0000 (14:08 +0000)]
a11y: Add GValue initializers for accessible attributes
Consumers of the GValue-based API for GtkAccessible need to have a way
to initialize the GValue with the correct type for the given attribute.
Emmanuele Bassi [Tue, 10 Nov 2020 11:02:35 +0000 (11:02 +0000)]
a11y: Proxy GtkWidget:accessible-role
The accessible-role property in GtkWidget has three possible targets:
- the :accessible-role of a GtkATContext, if realized
- the accessible_role field of GtkWidgetPrivate
- the accessible_role field of GtkWidgetClassPrivate
When we set the accessible role of a widget using the GObject property
mechanism, we want to either set the GtkWidgetPrivate.accessible_role
field, if there's no ATContext *or* if the ATContext is not realized.
Conversely, when we get the accessible-role property we want to have a
series of fallbacks in place:
- if GtkAccessible.get_at_context() returns an ATContext, and that
ATContext is realized, return the :accessible-role of the context
- if GtkWidgetPrivate.accessible_role is not WIDGET, return the
stored accessible role
- return GtkWidgetClassPrivate.accessible_role
This should help catch the case of getting the accessible role of
widgets that override GtkAccessible.get_at_context(), like
GtkModelButton.
See: #3342
Matthias Clasen [Tue, 10 Nov 2020 14:07:54 +0000 (09:07 -0500)]
printdialog: Plug listmodel memory leaks
We were leaking references returned from g_list_model_get_item
in some places.
Matthias Clasen [Tue, 10 Nov 2020 14:07:40 +0000 (09:07 -0500)]
fontchooser: Plug listmodel memory leaks
We were leaking references returned from g_list_model_get_item
in some places.
Matthias Clasen [Tue, 10 Nov 2020 14:07:22 +0000 (09:07 -0500)]
columnview: Plug listmodel memory leaks
We were leaking references returned from g_list_model_get_item
in some places.
Matthias Clasen [Tue, 10 Nov 2020 14:07:01 +0000 (09:07 -0500)]
x11: Plug listmodel memory leaks
We were leaking references returned from g_list_model_get_item
in some places.
Matthias Clasen [Tue, 10 Nov 2020 14:06:37 +0000 (09:06 -0500)]
win32: Plug listmodel memory leaks
We were leaking references returned from g_list_model_get_item
in some places.
Matthias Clasen [Tue, 10 Nov 2020 14:05:55 +0000 (09:05 -0500)]
wayland: Plug listmodel memory leaks
We were leaking references returned from g_list_model_get_item
in some places.
Yuri Chornoivan [Tue, 10 Nov 2020 08:15:59 +0000 (08:15 +0000)]
Update Ukrainian translation
Yuri Chornoivan [Tue, 10 Nov 2020 07:58:38 +0000 (07:58 +0000)]
Update Ukrainian translation
Matthias Clasen [Tue, 10 Nov 2020 04:47:28 +0000 (04:47 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2803
Matthias Clasen [Tue, 10 Nov 2020 02:04:52 +0000 (21:04 -0500)]
gtk-demo: Plug a memory leak
Matthias Clasen [Tue, 10 Nov 2020 01:07:09 +0000 (20:07 -0500)]
gtk-demo: Tweak a demo title
Matthias Clasen [Tue, 10 Nov 2020 01:42:30 +0000 (01:42 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
See merge request GNOME/gtk!2802
Matthias Clasen [Tue, 10 Nov 2020 01:07:09 +0000 (20:07 -0500)]
gkt-demo: Add a columview to the scroll demo
This is an interesting case, since it has many labels,
and we are struggling to provide good scrolling performance.
Matthias Clasen [Tue, 10 Nov 2020 00:54:17 +0000 (19:54 -0500)]
gtk-demo: Improve consistency
Make the shortcut triggers demo big enough
to not ellipsize the window title.
Matthias Clasen [Tue, 10 Nov 2020 00:53:44 +0000 (19:53 -0500)]
gtk-demo: Improve consistency
Make the paintable svg demo follow the same
pattern we use for other demos.
Matthias Clasen [Tue, 10 Nov 2020 00:52:28 +0000 (19:52 -0500)]
gtk-demo: Improve consistency
Make the paintable emblems demo follow the same
pattern we use for other demos.
Matthias Clasen [Mon, 9 Nov 2020 23:50:43 +0000 (18:50 -0500)]
gtk-demo: Set default size for drawingarea demo
Set a default size, so we don't ellipsize the window
title when the window is presented.
Matthias Clasen [Mon, 9 Nov 2020 18:03:01 +0000 (13:03 -0500)]
gtk-demo: Plug a memory leak
Matthias Clasen [Mon, 9 Nov 2020 18:02:43 +0000 (13:02 -0500)]
gtk-demo: Plug a memory leak
Matthias Clasen [Mon, 9 Nov 2020 19:38:55 +0000 (14:38 -0500)]
a11y: Clean up properly in unregister_object
Things that are set up in register_object should
be cleaned up in unregister_object.
Matthias Clasen [Mon, 9 Nov 2020 22:41:41 +0000 (22:41 +0000)]
Merge branch 'wip/jimmac/search-entry-icon' into 'master'
search entry: icon
Closes #3340
See merge request GNOME/gtk!2801
Jakub Steiner [Mon, 9 Nov 2020 21:55:21 +0000 (22:55 +0100)]
search entry: icon
Fixes https://gitlab.gnome.org/GNOME/gtk/-/issues/3340
Matthias Clasen [Mon, 9 Nov 2020 17:19:12 +0000 (17:19 +0000)]
Merge branch 'ebassi/for-master' into 'master'
docs: Add missing a11y environment variables
See merge request GNOME/gtk!2788
Matthias Clasen [Mon, 9 Nov 2020 17:14:03 +0000 (17:14 +0000)]
Merge branch 'kinetic-scroll-velocity-accumulation' into 'master'
scrolledwindow: Accumulate velocity with kinetic scrolling
See merge request GNOME/gtk!2768
Emmanuele Bassi [Sat, 7 Nov 2020 12:50:11 +0000 (12:50 +0000)]
a11y: Consolidate accessibility environment variables
Use a single environment variable for everything:
- select the ATContext implementation
- select the test ATContext
- disable ATContext entirely
We use the same pattern as GSK_RENDERER, GTK_DEBUG, etc.
The documentation needs to be updated to include the environment
variable.
Chris Lord [Fri, 30 Oct 2020 18:36:53 +0000 (18:36 +0000)]
scrolledwindow: Accumulate velocity with kinetic scrolling
Accumulate existing velocity when decelerating from a swipe if the swipe
velocity is above a certain fraction of that existing velocity.
Matthias Clasen [Mon, 9 Nov 2020 14:21:26 +0000 (14:21 +0000)]
Merge branch 'matthiasc/for-master' into 'master'
Matthiasc/for master
Closes #3337
See merge request GNOME/gtk!2799
Matthias Clasen [Sun, 8 Nov 2020 15:40:20 +0000 (10:40 -0500)]
Remove GtkPlacesOpenFlags from public headers
The GtkPlacesOpenFlags enum is only used in private
API, so move it to private headers. Since we still need
a GType for it, add gtkplacessidebarprivate.h to the
headers we use for generating private enum types. In turn,
this registers the other private enums in that header, so
take the opportunity to fix their naming, and use the
generated types for the corresponding sidebarrow properties.
Fixes: #3337
Matthias Clasen [Sun, 8 Nov 2020 14:58:26 +0000 (09:58 -0500)]
docs: Document GTK_MEDIA
Add a paragraph about the GTK_MEDIA environment variable.
Matthias Clasen [Sun, 8 Nov 2020 02:36:34 +0000 (21:36 -0500)]
Revert "Update gtktreestore.c: gtk_tree_store_remove didn't have the proper comment annotation"
This reverts commit
32baa0a54990abec3c60deb0ee8008fbbfc9a809.
See discussion in https://gitlab.gnome.org/GNOME/gtk/-/issues/78
for the background.